Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add side nav to join notify and contact page #2246

Merged
merged 4 commits into from
Jan 8, 2025

Conversation

heyitsmebev
Copy link
Contributor

add side nav to join notify and contact page

BEFORE
image

AFTER
image

@heyitsmebev heyitsmebev self-assigned this Jan 3, 2025
@heyitsmebev
Copy link
Contributor Author

@dmvancura Hi! Do you want the side nav for Join Notify and Contact page? If so, this is the PR for it.

@dmvancura
Copy link

yes, for this first release of "phase 2" content, we're going with both main nav and side-nav items. i'll do the PR review!

@dmvancura
Copy link

can i see the Join Notify side-nav items open once a user clicks on the main join notify side-nav (or main nav) item? like the behavior in the prototype here. thanks!

Copy link

@dmvancura dmvancura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added a comment about the join notify part and needing to be able to see all its side nav items upon first click to Join Notify section. check the prototype link. thanks!

@heyitsmebev
Copy link
Contributor Author

added a comment about the join notify part and needing to be able to see all its side nav items upon first click to Join Notify section. check the prototype link. thanks!

@alexjanousekGSA is working on this behavior in another PR @dmvancura

@heyitsmebev heyitsmebev linked an issue Jan 7, 2025 that may be closed by this pull request
Copy link
Contributor

@jonathanbobel jonathanbobel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonathanbobel jonathanbobel merged commit 7534de0 into main Jan 8, 2025
11 checks passed
@jonathanbobel jonathanbobel deleted the 2240-add-join-notify-to-the-main-nav branch January 8, 2025 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

move 'Contact' up into the public main navigation
3 participants